Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Layouts): fix propTypes error in StickyLayout #3261

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

kalzoo
Copy link
Contributor

@kalzoo kalzoo commented Nov 6, 2018

since fixed is an enum type, sending false instead of undefined causes a proptypes error:

Warning: Failed prop type: Invalid prop `fixed` of value `false` supplied to `Menu`, expected one of ["left","right","bottom","top"].
    in Menu (created by Context.Consumer)
    in HeaderFooter (created by Layout)
    in Query
    in Unknown (created by Route)
    in Route (created by withRouter())
    in withRouter() (created by Layout)
    in Layout (created by App)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by App)
    in ApolloProvider (created by App)
    in App

since `fixed` is an enum type, sending `false` instead of `undefined` causes a proptypes error:

```
Warning: Failed prop type: Invalid prop `fixed` of value `false` supplied to `Menu`, expected one of ["left","right","bottom","top"].
    in Menu (created by Context.Consumer)
    in HeaderFooter (created by Layout)
    in Query
    in Unknown (created by Route)
    in Route (created by withRouter())
    in withRouter() (created by Layout)
    in Layout (created by App)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by App)
    in ApolloProvider (created by App)
    in App

```
@welcome
Copy link

welcome bot commented Nov 6, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3261 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3261   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2802     2802           
=======================================
  Hits         2800     2800           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10219af...c8f0d87. Read the comment docs.

@layershifter layershifter changed the title Prevent PropTypes error fix(Layouts): fix propTypes error in StickyLayout Nov 7, 2018
@layershifter layershifter merged commit dfcbdd5 into Semantic-Org:master Nov 7, 2018
@welcome
Copy link

welcome bot commented Nov 7, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants