fix(Accordion): log error if incorrect activeIndex type #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
==========================================
+ Coverage 99.92% 99.92% +<.01%
==========================================
Files 169 169
Lines 2790 2801 +11
==========================================
+ Hits 2788 2799 +11
Misses 2 2
Continue to review full report at Codecov.
|
layershifter
changed the title
|
@SimonKinds finally merged, thanks for your work 👍 Sorry for delay, there were issues with Codecov, only manual changes fixed them:
|
|
No worries, thanks for being a wonderful maintainer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #3193, this fix ensures that an Accordion will log an error if the incorrect type is given for
activeIndex.The expected types are:
numberifexclusivearrayif notexclusiveIt will not log in production.
At first I considered doing the logging in the same lifecycle method that is used in
Dropdown, however it uses the now deprecatedcomponentWillReceiveProps. That's why I chose to log it incomponentDidUpdateIn #3193 we also discussed further documentation, but I noticed that there is already an example of how to use an Accordion when
exclusiveis false.I chose to not fix the crash that might occur when clicking a panel if the incorrect type for
activeIndexis given, as the warning will be printed beforehand. If you feel this should be fixed, let me know.You may go ahead and close #3192 , as this logging fixes the issue I had with it.