Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Advertisement): update a base Advertisement example #3179

Merged
merged 2 commits into from
Sep 29, 2018

Conversation

layershifter
Copy link
Member

Why?

AdBlock blocks loading of Advertisement examples and docs will throw 404, see #3164. I've created a fully working example on Codesandbox (https://codesandbox.io/s/6yo47owp9n).

@codecov-io
Copy link

Codecov Report

Merging #3179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3179   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         163      163           
  Lines        2746     2746           
=======================================
  Hits         2744     2744           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3d4d0...53a3ff3. Read the comment docs.

@layershifter layershifter merged commit b97de42 into master Sep 29, 2018
@layershifter layershifter deleted the fix/advertisment-remove-adsence branch September 29, 2018 11:03
@layershifter layershifter changed the title docs(Advertisement): update a base Advertisement docs(Advertisement): update a base Advertisement example Sep 29, 2018
@levithomason
Copy link
Member

Released in semantic-ui-react@0.83.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants