-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown|Modal|TextArea): update refs handlers #1360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 140 140
Lines 2345 2346 +1
==========================================
+ Hits 2339 2340 +1
Misses 6 6
Continue to review full report at Codecov.
|
src/addons/TextArea/TextArea.js
Outdated
@@ -60,6 +60,8 @@ class TextArea extends Component { | |||
this.updateHeight(e.target) | |||
} | |||
|
|||
handleRef = c => (this.rootNode = c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we should also standardize these ref variable names. We currently use *Node
, _*
and *Ref
in various places.
A ref can either be a node (DOM component) or a reference to a class instance (Composite component). Due to this, I vote we go with this.*Ref
for clarity and accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it makes sense 👍
Do I have to change the names to these?
-handleRef = c => (this.rootNode = c)
+handleRef = c => (this.textAreaRef = c)
-handleSearchRef = c => (this._search = c)
+handleSearchRef = c => (this.searchRef = c)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right to my eyes 👍
I've updated the refs per our agreement. Refs at the root I simply used Give it a look over and let me know if we're good to go here. |
I've updated |
* fix(Dropdown|Modal|TextArea): update refs handlers * fix(TextArea): update ref names * fix(Form): update ref names * fix(Checkbox): update ref names * fix(Dimmer): update ref names * fix(Dropdown): update ref names * fix(Modal): update ref names * fix(Popup): update ref names * style(Checkbox): update ref handler
Released in |
Addresses #607.