[java] Using Selenium Manager for Java tests

SeleniumHQ · Feb 17, 2023 · 8b4b818 · 8b4b818
1 parent b1300a6
commit 8b4b818
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/common/BUILD.bazel b/common/BUILD.bazel
@@ -55,7 +55,7 @@ alias(
 config_setting(
     name = "use_local_chromedriver",
     flag_values = {
-        "@local_drivers//:use_chromedriver": "true",
+        "@local_drivers//:use_chromedriver": "false",
         ":pin_browsers": "false",
     },
 )
@@ -68,7 +68,7 @@ alias(
 config_setting(
     name = "use_local_geckodriver",
     flag_values = {
-        "@local_drivers//:use_geckodriver": "true",
+        "@local_drivers//:use_geckodriver": "false",
         ":pin_browsers": "false",
     },
 )
@@ -81,7 +81,7 @@ alias(
 config_setting(
     name = "use_local_msedgedriver",
     flag_values = {
-        "@local_drivers//:use_msedgedriver": "true",
+        "@local_drivers//:use_msedgedriver": "false",
         ":pin_browsers": "false",
     },
 )

diff --git a/java/browsers.bzl b/java/browsers.bzl
@@ -7,11 +7,9 @@ chrome_jvm_flags = select({
         "-Dwebdriver.chrome.driver=$(location @mac_chromedriver//:chromedriver)",
         "-Dwebdriver.chrome.binary=$(location @mac_chrome//:Chromium.app)/Contents/MacOS/Chromium",
     ],
-    "@selenium//common:use_local_chromedriver": [
-        "-Dwebdriver.chrome.driver=$(location @selenium//common:chromedriver)",
-    ],
+    "@selenium//common:use_local_chromedriver": [],
     "//conditions:default": [
-        "-Dselenium.skiptest=true",
+        "-Dselenium.skiptest=false",
     ],
 }) + select({
     "@selenium//common:use_headless_browser": [
@@ -25,11 +23,9 @@ edge_jvm_flags = select({
         "-Dwebdriver.edge.driver=$(location @mac_edgedriver//:msedgedriver)",
         "-Dwebdriver.edge.binary=\"$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft Edge\"",
     ],
-    "@selenium//common:use_local_msedgedriver": [
-        "-Dwebdriver.edge.driver=$(location @selenium//common:msedgedriver)",
-    ],
+    "@selenium//common:use_local_msedgedriver": [],
     "//conditions:default": [
-        "-Dselenium.skiptest=true",
+        "-Dselenium.skiptest=false",
     ],
 }) + select({
     "@selenium//common:use_headless_browser": [
@@ -47,11 +43,9 @@ firefox_jvm_flags = select({
         "-Dwebdriver.gecko.driver=$(location @mac_geckodriver//:geckodriver)",
         "-Dwebdriver.firefox.bin=$(location @mac_firefox//:Firefox.app)/Contents/MacOS/firefox",
     ],
-    "@selenium//common:use_local_geckodriver": [
-        "-Dwebdriver.gecko.driver=$(location @selenium//common:geckodriver)",
-    ],
+    "@selenium//common:use_local_geckodriver": [],
     "//conditions:default": [
-        "-Dselenium.skiptest=true",
+        "-Dselenium.skiptest=false",
     ],
 }) + select({
     "@selenium//common:use_headless_browser": [