Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add model_instance explanation #567

Merged

Conversation

goasleep
Copy link
Contributor

Linking #560

It seems that there are examples in the documentation that use this parameter model_instance, but this is not particularly easy to find, so it is listed separately in the documentation.

@goasleep goasleep force-pushed the feature/add_model_instance_info branch from f2ba107 to 4a9d849 Compare August 21, 2024 02:11
@VinciGit00
Copy link
Collaborator

does moonshot work on scrapegraph? we did not integrated them

@f-aguzzi
Copy link
Member

@VinciGit00 this is related to issue #560 - @goasleep wanted to use an unsupported model with an OpenAI - like API, and figured out that he could use model instances to do so. It seems to work. This means we have a new use for model instances. I suggested we could add Moonshot directly, but goalsleep didn't think it was necessary at the moment.

@f-aguzzi
Copy link
Member

@goasleep thanks for the idea and for the contribution - we'll wait for VinciGit's opinion and then merge your pull request.

@goasleep
Copy link
Contributor Author

goasleep commented Aug 21, 2024

Yeah. it's working well.But I did not submit unit test cases to avoid adding additional complexity because a new api key was added. Here is a test example.
image

  • env:
    • device:macbook air m3
    • os system: macos 14.6.1
    • python version: 3.12.4

@f-aguzzi
Copy link
Member

Thanks a lot. Don't worry about the test cases - these things are hard to automate without having API keys for each provider. We have the same problem.

Maybe we could add a subfolder of model instance examples to the examples folder, though. We'll see.

@goasleep
Copy link
Contributor Author

I sorry for adding the examples to this branch... Could you help to approval again?

@VinciGit00
Copy link
Collaborator

can you add also inside the folder examples/moonshor?

@goasleep
Copy link
Contributor Author

can you add also inside the folder examples/moonshor?

Sure. I submitted a new commit

@VinciGit00 VinciGit00 changed the base branch from main to pre/beta August 21, 2024 11:43
@VinciGit00 VinciGit00 merged commit 437e48f into ScrapeGraphAI:pre/beta Aug 21, 2024
2 checks passed
Copy link

🎉 This issue has been resolved in version 1.15.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants