Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations for the new v5 SciTools CLA #2306

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Dec 22, 2023

Rationale

Reference the upcoming new SciTools Contributor Licence Agreement (v5), which is being implemented to comply with legal advice from the UK Met Office - see #1919 (comment) .

I have chosen to no longer link to scitools.org.uk, since the new CLA is designed to be 'self-describing' without needing other exposition, hence the new Summary section at the top.

This is has been set up - via CLA Assistant - in most SciTools repositories on 2023-12-22. Cartopy has been exempted to allow time for people to see and discuss. We could add further documentation, and even altering the CLA's summary text would be OK at this point because very few people would need to re-sign.

Implications

All pull request authors will be automatically asked to sign the CLA as part of the continuous integration checks. An example of such a check is here: SciTools-incubator/iris-esmf-regrid#239 (comment) .

The intention is to apply a branch protection rule that prevents merges to main unless all commit authors have signed the CLA, achieved by checking for a ✔ from this CI check.

@trexfeathers
Copy link
Contributor Author

pre-commit.ci autofix

@trexfeathers
Copy link
Contributor Author

ping @SciTools/cartopy-devs

@rcomer
Copy link
Member

rcomer commented Dec 22, 2023

Does #2285 need to be merged before this?

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Dec 22, 2023

Does #2285 need to be merged before this?

No, they are only related in a conceptual sense. Neither references the other, and @lbdreyer has already put in the heroics to get approval for re-licensing from the existing authors, so we are not dependent on the new CLA for permission to do that.

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I'll leave this open for others to review.

@bjlittle bjlittle self-requested a review December 23, 2023 23:05
@greglucas greglucas merged commit 0ed6c8f into SciTools:main Feb 14, 2024
22 checks passed
@QuLogic QuLogic added this to the 0.23 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants