Add xfails to current owslib failures #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds xfails to the NASA server requests that are failing due to upstream issues that we can't control. This can be reverted if/when NASA or owslib update their codebases.
The current url was returning a 404. I looked for the same image name elsewhere on NASA and found this spot which looks reasonable.
greglucas
force-pushed
the
owslib-xfail
branch
from
646575e
to
dbdcfa1
Compare
greglucas
commented
Oct 7, 2023
docs/source/conf.py
Outdated
| @@ -93,6 +93,13 @@ | |||
| sphinx_gallery_conf = { | |||
| 'capture_repr': (), | |||
| 'examples_dirs': ['../../examples'], | |||
| # NASA wmts servers are returning bad content metadata | |||
| "expected_failing_examples": [ | |||
| '../../examples/scalar_data/eyja_volcano.py', | |||
There was a problem hiding this comment.
It seems like these two are flaky right now. I get failures when I remove them. I get failures when I add them :) Not sure if there is a way to say something is flaky in sphinx gallery?
Suggested change
| '../../examples/scalar_data/eyja_volcano.py', | |
| '../../examples/scalar_data/eyja_volcano.py', | |
| '../../examples/web_services/image_tiles.py', |
There was a problem hiding this comment.
Apparently the Stamen tiles have moved https://stackoverflow.com/questions/77248120/stamen-terrain-map-not-working-in-cartopy
There was a problem hiding this comment.
Interesting, I did not realize that was going away. Let's follow that up in a separate PR then and leave the docs failing here for now.
greglucas
force-pushed
the
owslib-xfail
branch
from
dbdcfa1
to
d16768e
Compare
rcomer
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds xfails to all of the 10 current failures in the test suite. It also adds the failing documentation examples to the expected failures there as well.
In addition, running the examples locally I noticed that there is now a 404 from the Vesta image example, so another commit to change the URL for that example.