Fix gridliner when datalim updated by constrained layout #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
commented
Oct 2, 2023
| array=[1, 2, 3, 4], | ||
| ) | ||
| ax.add_collection(collection) | ||
| fig.colorbar(collection, ax=ax, location='right') |
There was a problem hiding this comment.
The problem does show up if the colorbar isn't included, but is less obvious.
rcomer
changed the title
greglucas
reviewed
Oct 3, 2023
| @@ -481,11 +481,12 @@ def _draw_preprocess(self, renderer): | |||
| if self.get_autoscale_on() and self.ignore_existing_data_limits: | |||
| self.autoscale_view() | |||
|
|
|||
| self.apply_aspect() | |||
There was a problem hiding this comment.
Add a comment indicating this needs to come before the other updates so we don't accidentally move it somewhere else later.
| ax.autoscale() | ||
|
|
||
| # Add some gridlines | ||
| ax.gridlines(draw_labels=["bottom", "left"], auto_update=True) |
There was a problem hiding this comment.
Would it help to have the gridlines "solid" rather than dashed for these tests? I feel like sometimes the tolerances are because some of the dashes slightly moving along the line rather than the full line moving up/down. Maybe that is just my eyes though.
rcomer
force-pushed
the
gridliner-constrained
branch
from
cce20d6
to
8fb8caf
Compare
rcomer
force-pushed
the
gridliner-constrained
branch
from
8fb8caf
to
caa4745
Compare
greglucas
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Fixes #2245. See #2245 (comment) for an explanation.
Implications