CI: Change pip install pin for releasing #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up when updating the wheels matrix generation to use a hash instead of the version.
#2197 (comment)
This is just for generating the wheels matrix of jobs and really shouldn't matter what specific version to use. So, rather than installing via a hash through github, lets just reference the pypi release version. This portion is less critical than below in actually building the wheels where we are able to reference the commit hash through the GitHub Actions specific utility.
I verified this on my fork: https://github.com/greglucas/cartopy/actions/runs/5766395153
After this is merged I will delete the old release from GitHub and make a new one with the same content and move the tag, which will trigger the release process again (since it failed last time).