pre-commit: adopt sort-all hook #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
force-pushed
the
adopt-sort-all
branch
from
725466b
to
15415ab
Compare
dopplershift
approved these changes
Mar 13, 2023
|
Need to fix up conflicts. |
bjlittle
force-pushed
the
adopt-sort-all
branch
from
15415ab
to
ba15358
Compare
dopplershift
approved these changes
Mar 13, 2023
|
@dopplershift I suspect I'm going have conflicts after each merge to We can iterate piecemeal on each individual PR, one at a time, if that works for you? |
bjlittle
commented
Mar 13, 2023
bjlittle
force-pushed
the
adopt-sort-all
branch
from
ba15358
to
f5e1ac0
Compare
|
@dopplershift Good to go 👍 |
|
Sweet, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the sort-all pre-commit git hook to enforce an opinionated sort order of
__all__statements throughout the code-base.Reference: #1934