Fix image tests #2058
Merged
Fix image tests #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could not review pull request. It may be too large, or contain no reviewable changes. |
greglucas
requested changes
Jun 28, 2022
There was a problem hiding this comment.
The inline_usa images are supposed to skipped. They hit the pytest.skip() call, but pytest-mpl still compares the images even though it was skipped. I think this is likely a recent update on the pytest-mpl side. I guess I'd suggest we don't add the images and raise an issue upstream for them to fix that use-case.
|
Ah, I see it now. I'll force |
dopplershift
force-pushed
the
fix-image-tests
branch
2 times, most recently
from
284c145
to
7a835c3
Compare
stickler-ci
reviewed
Jun 28, 2022
dopplershift
force-pushed
the
fix-image-tests
branch
from
7a835c3
to
a8f3c15
Compare
These only minimally changed with a shifting of the dashes in the gridlines, but no substantive changes.
This version has a bug where it ignores our skip in some parametrized tests.
greglucas
approved these changes
Jun 28, 2022
dopplershift
force-pushed
the
fix-image-tests
branch
from
a8f3c15
to
b67b269
Compare
QuLogic
approved these changes
Jun 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing failing image tests in CI.
* We apparently had some missing images in the parametrized tests (Parametrize inline gridliner tests #1900) that pytest-mpl is now complaining about. I have no idea if these are actually correct, but they're the current behavior.pytest-mpl!=0.16.0Alternatively for the second problem, if anyone knows if the projections make absolutely no sense for the US domain, we could just remove them from the list for that test.