Fix bad import in setup.py #2025
Conversation
SciTools-assistant
added
the
Blocked: CLA needed
| @@ -31,8 +31,9 @@ | |||
| import warnings | |||
| from collections import defaultdict | |||
| from sysconfig import get_config_var | |||
| from distutils.util import convert_path | |||
There was a problem hiding this comment.
E402 module level import not at top of file
setup.py
Outdated
|
|
||
| from setuptools import Command, Extension, convert_path, setup | ||
| from setuptools import Command, Extension, setup |
There was a problem hiding this comment.
F401 'setuptools.Command' imported but unused
E402 module level import not at top of file
SciTools-assistant
removed
the
Blocked: CLA needed
| from sysconfig import get_config_var | ||
|
|
||
| from setuptools import Command, Extension, convert_path, setup | ||
| from setuptools import Extension, setup |
There was a problem hiding this comment.
E402 module level import not at top of file
There was a problem hiding this comment.
Unsure what to do here, want to keep it in the style of the original code, however the original code doesn't have a lint ignore comment. Should one be added?
There was a problem hiding this comment.
Don't worry about it; setup.py is excluded in setup.cfg, but I guess stickler doesn't check that config file.
|
I actually don't see any point in using In fact, I don't see the point in either, since Windows understands |
|
@glentakahashi, sorry I opened another PR without realizing you'd already opened this (#2026). I don't think we want distutils here. I agree we can probably just remove the |
|
Ah @greglucas your version is better, so I'll close this one out and we should use yours |
|
@glentakahashi I just opened #2027 with yet another approach. Can you comment over there if that works for you too? |
Fixes #2021