Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport recent master commits to v0.20.x #1969

Merged
merged 6 commits into from
Dec 25, 2021

Conversation

greglucas
Copy link
Contributor

Rationale

This backports the pcolormesh bounds commit that went into master to v0.20.x and also brings along the CI fixes as well so that the tests will hopefully pass.

This was missed in the pcolormesh refactor causing some incorrect
bounds calculations when plotting the data.
Natural Earth version 5 updated some features, which caused
this test to fail the tolerance. Update the image with the new
features and remove the old forced edgecolor.
There is some conda-forge issue with Shapely/geos
so switch over to Linux for the min dependency tests.
@greglucas
Copy link
Contributor Author

Hm... A bunch of WMTS failures now. Not sure if there is something else that needs backporting from master, or if this is some other connection issue...

This branch has a different set of updates, causing some of the
test tolerances to be changed. Two of these natural earth tests
are different because the shapefiles have recently been updated
and some features are different now. (For instance, the lakes
in the shapefile are now different)
@greglucas greglucas mentioned this pull request Dec 16, 2021
@QuLogic QuLogic added this to the 0.20.2 milestone Dec 18, 2021
@QuLogic
Copy link
Member

QuLogic commented Dec 24, 2021

Those seem to be failing on master as well now.

The negotiation with a tile provider needed more up-to-date
TLS/SSL protocols, so for now we just pin to a lower openssl
on the runners.
Partial cherry-pick of 579be04
to increase the test tolerance of the images for MPL3.5 tests.
@QuLogic QuLogic merged commit 96f77d9 into SciTools:v0.20.x Dec 25, 2021
@greglucas greglucas deleted the v0.20-pcolormesh branch January 12, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants