Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Get the versions of the software used in the MultiQC report #595

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

maxulysse
Copy link
Member

  • Add new bin/scrape_tool_versions.py inspired by @ewels and @apeltzer
  • Add new processes and containers to get the versions of the tool used
  • Replace GenerateMultiQCconfig process by createMultiQCconfig() function
  • Use new SarekUtils.defineDirectoryMap() function instead of in script defineDirectoryMap() function
  • Add forgotten QC steps
  • Code polishing

@maxulysse
Copy link
Member Author

I'll definitively need to squash some commit together on this PR.
It's not that big actually, but there was a lot of trials and errors...

@maxulysse
Copy link
Member Author

@ewels @apeltzer I had some fun making a library with some QC stuff, I think it could be interesting to use such a library system in nf-core, once we manage to sort out the reproducibility.

@ewels
Copy link
Member

ewels commented Jun 1, 2018

wow, time for some git rebase maybe..? 😆

@@ -14,6 +14,21 @@ process {
$BuildVCFIndex.container = "${params.repository}/igvtools:${params.tag}"
$ConcatVCF.container = "${params.repository}/sarek:${params.tag}"
$CreateRecalibrationTable.container = "${params.repository}/gatk:${params.tag}"
$GetVersionAll.container = "${params.repository}/qctools:${params.tag}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be possible to tidy up the configs here quite a bit with the new nextflow concept of label (in new versions of NF only)

@maxulysse
Copy link
Member Author

I think I was a little too extreme with my rebase...

Copy link
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks Groovy is the next language I have to learn ...

@szilvajuhos szilvajuhos merged commit f41a3bd into SciLifeLab:master Jun 12, 2018
@maxulysse maxulysse deleted the MultiQC branch June 12, 2018 14:38
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Get the versions of the software used in the MultiQC report
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants