Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for QPTIFF #55

Merged
merged 4 commits into from
May 10, 2024

Conversation

adamjtaylor
Copy link
Collaborator

QPTIFF is a TIFF-based image format used by PerkinsElmer Vecra mIF and Akoya Phenocycler CODEX instruments. This PR adds basic support for them by including files with the .qptiff extension in the TIFF file type.

Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, have you run any .qptiff files through the TiffSuite? I'm assuming they would pass all of the normal .tif tests (except for file extension until after this is merged), but it might be good to make sure.

src/dcqc/file.py Outdated Show resolved Hide resolved
Co-authored-by: Brad Macdonald <52762200+BWMac@users.noreply.github.com>
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamjtaylor adamjtaylor requested a review from a team as a code owner May 10, 2024 22:18
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm guessing the one acceptance test is failing because this contribution is coming from a fork which doesn't have a Synapse Auth token with the necessary permissions. The test suite passes locally for me and the change is tiny so I think we are safe to merge this. I will be sure tests all pass before releasing a patch with this change.

Thanks for the contribution @adamjtaylor!

Edit: Also for clarity, I ran a test run of DCQC with a QPTIFF file and it worked as expected.

@BWMac BWMac merged commit d219b8e into Sage-Bionetworks-Workflows:main May 10, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants