Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate VS Code languages for pipeline/stub/tests #1043

Merged
merged 7 commits into from
Apr 14, 2024

Conversation

lars-reimann
Copy link
Member

Summary of Changes

  • Pipeline files, stub files, and test files now get assigned separate language IDs in VS Code. This is needed to better control various activation events.
  • Change the file extension .sdspipe to .sds. It's what users actually interact with, so it should be short.
  • Change the file extension .sdstest to .sdsdev. sdstest might have suggested that users can use this to test their programs.

Copy link

github-actions bot commented Apr 14, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 8 0 0 1.68s
✅ JSON jsonlint 8 0 0.22s
✅ JSON npm-package-json-lint yes no 0.85s
✅ JSON prettier 8 0 0 1.4s
✅ JSON v8r 8 0 10.46s
✅ MARKDOWN markdown-link-check 10 0 0.51s
✅ PYTHON black 1 0 0 0.9s
✅ PYTHON mypy 1 0 2.29s
✅ PYTHON ruff 1 0 0 0.23s
✅ REPOSITORY git_diff yes no 0.2s
✅ TYPESCRIPT eslint 17 0 0 7.98s
✅ TYPESCRIPT prettier 17 0 0 2.19s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb57481) to head (1be8029).
Report is 124 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1043   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines        19037     19037           
  Branches      3900      3900           
=========================================
  Hits         19037     19037           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review April 14, 2024 12:21
@lars-reimann lars-reimann merged commit 8147480 into main Apr 14, 2024
7 checks passed
@lars-reimann lars-reimann deleted the separate-languages branch April 14, 2024 12:21
lars-reimann pushed a commit that referenced this pull request Apr 18, 2024
## [0.12.0](v0.11.0...v0.12.0) (2024-04-18)

### Features

* better error if `+` is used for string concatenation ([#1044](#1044)) ([8be49c5](8be49c5))
* collapse class/literal types in inlay hints ([#1053](#1053)) ([7db2820](7db2820)), closes [#1048](#1048)
* **deps:** require latest runner (`v0.11.0`) ([#1058](#1058)) ([7ae1f6b](7ae1f6b))
* don't stop validation at syntax errors ([#1049](#1049)) ([db0c5d7](db0c5d7))
* error if name of static member equals name of inherited member ([#1054](#1054)) ([b8e17af](b8e17af))
* hide classes that are only for typing from auto-completion ([#1056](#1056)) ([50851d7](50851d7)), closes [#1026](#1026)
* ignore parameter names for default values and yields ([#1059](#1059)) ([dde4de0](dde4de0))
* ignore parameter names when type checking arguments ([#1052](#1052)) ([a1e6717](a1e6717)), closes [#1046](#1046)
* installer for the runner ([#1038](#1038)) ([2bde594](2bde594))
* map literals are no longer experimental ([#1039](#1039)) ([1d9af4b](1d9af4b))
* separate VS Code languages for pipeline/stub/tests ([#1043](#1043)) ([8147480](8147480))
* support for examples in documentation comments ([#1045](#1045)) ([3da6d6f](3da6d6f)), closes [#1027](#1027)
* updater for the runner ([#1042](#1042)) ([610d45b](610d45b))

### Bug Fixes

* don't sync `safe-ds.runner.command` setting ([bb57481](bb57481))
* save all files before opening the EDA tool ([d6d0c22](d6d0c22))
* start runner if configuration did not change after installation ([#1040](#1040)) ([b4f015a](b4f015a))
* substitute type parameters for lambda parameters ([#1050](#1050)) ([46145dd](46145dd)), closes [#1047](#1047)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants