Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test utility functions: importskip(), serverskip() #906

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Aug 9, 2024

Description

Added test utility function serverskip() to skip a test if a needed server is down.
Also added importskip() for convenience.

Motivation for this PR: Avoid that tests fail when services like play.min.io are down.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but I think this will easily end up resulting in tests not running when we should not miss that they are failing. I think this PR might have unintened repercussions.

@jesper-friis jesper-friis merged commit e7a4408 into master Aug 12, 2024
14 checks passed
@jesper-friis jesper-friis deleted the serverskip branch August 12, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants