-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer default values for the uuid
and single
options of asdict()
#833
Conversation
Updated affected tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR changes default behavior of asdict.
Since it is only a change in the defaults, no features are added or removed. I think this code can be merged after a bump in minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok. Please increment the minor version in the next release.
Description
See comments in issue #811
Infer default values for the
uuid
andsingle
options of asdict() to None.Note: This PR changes the behaviour of DLite and may break existing code.
All tests that are affected by this change have been updated.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.