Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer default values for the uuid and single options of asdict() #833

Merged
merged 8 commits into from
Jun 25, 2024

Conversation

jesper-friis
Copy link
Collaborator

Description

See comments in issue #811

Infer default values for the uuid and single options of asdict() to None.

Note: This PR changes the behaviour of DLite and may break existing code.

All tests that are affected by this change have been updated.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue May 1, 2024 that may be closed by this pull request
@jesper-friis jesper-friis requested a review from sygout May 1, 2024 14:46
Copy link
Contributor

@torhaugl torhaugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes default behavior of asdict.

Since it is only a change in the defaults, no features are added or removed. I think this code can be merged after a bump in minor version.

Copy link
Contributor

@torhaugl torhaugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. Please increment the minor version in the next release.

@jesper-friis jesper-friis merged commit fea68ad into master Jun 25, 2024
15 checks passed
@jesper-friis jesper-friis deleted the 811-error-in-documentation-and-asdict branch June 25, 2024 18:27
@jesper-friis jesper-friis mentioned this pull request Jul 4, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in documentation and asdict
2 participants