Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setver task #244

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Update setver task #244

merged 3 commits into from
Feb 29, 2024

Conversation

CasperWA
Copy link
Collaborator

Properly implement fail_fast and the test parameters. Support PEP 440 Python versions.
Test the majority of the functionality and logic in the setver task.

Closes #243

Properly implement fail_fast and the test parameters.
Support PEP 440 Python versions.
Test the majority of the functionality and logic in the setver task.
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 79.71014% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 84.60%. Comparing base (f979d1f) to head (37d18de).

Files Patch % Lines
ci_cd/tasks/setver.py 80.70% 11 Missing ⚠️
ci_cd/utils/versions.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   81.29%   84.60%   +3.30%     
==========================================
  Files          12       12              
  Lines         909      942      +33     
==========================================
+ Hits          739      797      +58     
+ Misses        170      145      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ci_cd/tasks/setver.py Show resolved Hide resolved
ci_cd/tasks/setver.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Treesarj Treesarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments to resolve

@CasperWA CasperWA enabled auto-merge (squash) February 29, 2024 12:04
@CasperWA CasperWA merged commit fe1930d into main Feb 29, 2024
23 of 24 checks passed
@CasperWA CasperWA deleted the cwa/close-243-python-regex-setver-task branch February 29, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Python versioning regex in setver
2 participants