This repository has been archived by the owner on May 29, 2022. It is now read-only.
Allow client-code to treat SatPass as constant #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoided unnecessary copying of std::strings passed to getter methods. Improved support for treating SatPass objects as constants in client code.
Centralized out-of-bounds logic in SatPass getter/setter methods. Added typedef for index/label std::map types. Simplified copying of std::vectors within SatPassData.
Removed various unused variables. Reordered various constructor member initializers. Reduced usage of clang-specific #pragmas.
Temporarily set umask to 000 when checking FileUtils::makeDir().
Fixed various signed/unsigned mismatches etc.
Removed various redundant empty return statements. Removed unused (duplicated) time-printing shortcut() function. Patched various uninitialized variables and signed/unsigned mismatches.
|
Branch now updated to track upstream GPSTk-2.10 |
|
Before this pull request can be reviewed for the next stable release, please update the branch to resolve possible merge conflicts. |
Removed unused varible in StringUtils.hpp Removed one reference to temporary within NavFramer::Subframe::checkWords().
|
I've updated this branch to mirror gpstk-2.10.6, but the PRSolve_Rinexout test is failing. It's not obvious that this has anything to do with the changes I've been making. I suspect the issue is some form of counting error near line 340 of PRSolution.cpp where the indexing of the CRange and SVP arrays gets out of sync. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various methods within SatPass have changed since gpstk-2.6 which break client code which attempts to treat SatPass as a constant. Query methods like data() force the client to receive a non-constant reference even when they need read-only access to observation data.
Various patches have been added to SatPass which improve support for read-only access by clients using "const SatPass" objects. Also, various getter methods have been adjusted to take const std::string& to avoid unnecessary copying of string parameters that are not modified within GPSTk.