Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Visual Studio build #77

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Fix Visual Studio build #77

merged 1 commit into from
Oct 14, 2019

Conversation

tusharpm
Copy link
Member

Move #include <ciso646> to config.h which is included in all TUs.
Make it conditional for MSVC to limit the impending deprecation warning/removal error in C++20.

@tusharpm tusharpm added bugfix restores intended behavior windows Windows-specific issue labels Oct 14, 2019
TheJJ
TheJJ approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, you're the windows pro :D

@TheJJ TheJJ merged commit 08cc612 into SFTtech:master Oct 14, 2019
@simonsan
Copy link
Contributor

Yey, nice! Thanks tu! <3

@tusharpm tusharpm deleted the fix_win_build branch October 14, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
bugfix restores intended behavior windows Windows-specific issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tusharpm @simonsan @TheJJ