Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apf::smoothCAPAnisoSizes #455

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Add apf::smoothCAPAnisoSizes #455

merged 4 commits into from
Sep 23, 2024

Conversation

bobpaw
Copy link
Collaborator

@bobpaw bobpaw commented Sep 22, 2024 •
edited
Loading

Add apf::smoothCAPAnisoSizes

  • Capstone added support for a smoothing function. This PR provides a facade to call this smoothing function (if it is provided by Capstone) to smooth aniso sizes (when stored as apf::Fields of apf::Vector3 and apf::Matrix3x3s).
  • This capability is compiled only if Capstone support for the plugin is detected.
  • A test is added to ensure compilation passes successfully, but another more concrete test should be added eventually (see Add Capstone smoothing test #456).

@bobpaw
Add apf::smoothCAPAnisoSizes
367396e 
Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw
Add apf::smoothCAPAnisoSizes compile flags
594fd52 
- If given HAVE_CAPSTONE_SIZINGMETRICTOOL, compile apf_cap with C++14
  and link to framework_meshing.
- Install to CMAKE_INSTALL_INCLUDEDIR.
- Remove -I${CMAKE_BINARY_DIR} because there's no apf_capConfig.h.in.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw
Add feature test for sizing metric tool
91bbfe9 
- I had to add C++14 to the check_include_file_cxx call.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw
Add apf::smoothCAPAnisoSizes compilation test
ecc2e72 
- Add compilation test to check that the compile definition worked.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw bobpaw mentioned this pull request Sep 22, 2024
Open
@cwsmith
Copy link
Contributor

cwsmith commented Sep 23, 2024

/runtests

@github-actions GitHub Actions
Copy link

Build Log
Simmetrix Test Result: success
Simmetrix + CGNS Test Result: success

@cwsmith cwsmith merged commit 3e6ecac into develop Sep 23, 2024
4 checks passed
@cwsmith cwsmith deleted the apw/cap_smooth branch September 23, 2024 15:22
@bobpaw bobpaw mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwsmith cwsmith cwsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobpaw @cwsmith