feat(ItemNavigation): introduce navigationMode property #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prevents focusing next/prev item when pressing right/left arrow FIXES: #862
|
Why a property - we need both cases in order to cover all requirements. ActionSheet - horizontal navigation works fine - https://openui5nightly.hana.ondemand.com/#/entity/sap.m.ActionSheet/sample/sap.m.sample.ActionSheet |
ilhan007
previously approved these changes
Nov 11, 2019
pskelin
previously requested changes
Nov 11, 2019
There was a problem hiding this comment.
let's discuss the name first.
- if it is about vertical navigation, there will be a second property
- two properties about controlling the same behaviour seems strage
- there are four possible values, why not an enum?
- one of the four values doesn't make sense - both horizontal and vertical prevented
an enum might be more meaningful (both the name and the values):
navigationMode = { Horizontal, Vertical, Auto|Both|2D }
ilhan007
changed the title
vladitasev
approved these changes
Nov 27, 2019
ilhan007
pushed a commit
that referenced
this pull request
Dec 3, 2019
(1) The ItemNavigation now has three navigation modes: - "Vertical" - "Up|Down" navigation - "Horizontal"- "Left|Right" navigation - "Auto" - both "Vertical" and "Horizontal" navigation (2) From now you can navigate throw the List items and Table rows only vertically via the "Up" and "Down" arrow keys. FIXES: #862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) The ItemNavigation now has three navigation modes:
(2) From now you can navigate throw the List items and Table rows only vertically
via the "Up" and "Down" arrow keys.
FIXES: #862