refactor: unify asset handling #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- naming of location for LocaleData, i18n and Themes - naming of json import helpers for all assets - naming of registries that hold the registered locations of all assets
- remove old json import files - switch bundle themeing to JSON instead of inlined in JS
ResourceBundle stays as a class for now, the registry part is moved for consistency
vladitasev
previously approved these changes
Aug 28, 2019
vladitasev
previously approved these changes
Aug 28, 2019
theme parameters can be registered as URLs, as pure string, and now as JSON object as well.
vladitasev
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
/json-imports//assets//registries/