Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-list): remove backgroundDesign property #384

Merged
merged 2 commits into from
May 14, 2019

Conversation

ilhan007
Copy link
Member

  • Remove backgroundDesign property
  • Introduce css var: --_ui5_listitem_background_color for ui5-li
  • Introduce css var: --_ui5_group_header_listitem_background_color for ui5-li-groupheader

BREAKING CHANGE: the "backgroundDesign" property has been removed, use the corresponding
CSS variable (--_ui5_listitem_background_color) to alter the list items` background.

Copy link
Member

@MapTo0 MapTo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this change. Some things that come on my mind - we should:

  • consider a "guidelines" for the public variable names
  • add a section in the playground that describes them

@ilhan007
Copy link
Member Author

I am happy with this change. Some things that come on my mind - we should:

  • consider a "guidelines" for the public variable names
  • add a section in the playground that describes them

Yes, we talked about both points:
About the naming: we will research how they are named in the web in general (without the beginning underscore for sure)
And we also decided that we should have section in the playground, but not in details.

Do you mind making those later, after we come to common decision.

@ilhan007 ilhan007 merged commit 7839559 into master May 14, 2019
@ilhan007 ilhan007 deleted the remove-list-backgroundDesign branch May 14, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants