Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-panel): remove backgroundDesign property #383

Merged
merged 3 commits into from
May 14, 2019
Merged

refactor(ui5-panel): remove backgroundDesign property #383

merged 3 commits into from
May 14, 2019

Conversation

ilhan007
Copy link
Member

  • remove "backgroundDesign" property
  • introduce css vars: --_ui5_panel_background_color and --_ui5_panel_bottom_border_color to replace the property

BREAKING CHANGE: the "backgroundDesign" property has been removed, use the corresponding
CSS variables to alter the panel background.

@ilhan007 ilhan007 requested a review from pskelin May 13, 2019 14:10
@ilhan007 ilhan007 requested a review from fifoosid May 14, 2019 07:05
MapTo0
MapTo0 reviewed May 14, 2019
View reviewed changes
Copy link
Member

@MapTo0 MapTo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in the other change.

@ilhan007
Copy link
Member Author

Same as in the other change.

I replied in the other change

@ilhan007 ilhan007 merged commit 47aaa3d into master May 14, 2019
@ilhan007 ilhan007 deleted the panel-remove-bgDesign-prop branch May 14, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MapTo0 MapTo0 MapTo0 left review comments

@fifoosid fifoosid fifoosid approved these changes

@pskelin pskelin Awaiting requested review from pskelin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilhan007 @MapTo0 @fifoosid