fix: Several date/time components use locales correctly #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested review from
MapTo0,
pskelin,
tsanislavgatev,
ilhan007 and
fifoosid
ilhan007
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses several problems with the usage of locale-related classes in all date/time components:
languageAwaremissing for a couple of components that depend on locale dataLocaleData.jsused to be instantiated in the constructor for several components. This means that even if the locale changes at runtime, the instance ofLocaleData.jswill never update. Therefore it must be inonBeforeRenderinginstead.base/src/locale/Locale.jsandlocalization/LocaleData.jsclass instances can be reused among all components as they are read-only once initializedfixes: #2439