feat(framework): make getStableDomRef search in the static area item … #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested changes
Oct 16, 2020
packages/base/src/UI5Element.js
Outdated
| * @param {String} refName Defines the name of the stable DOM ref | ||
| */ | ||
| getStableDomRef(refName) { | ||
| return this.getDomRef().querySelector(`[data-ui5-stable=${refName}]`); | ||
| return this.staticAreaItemDomRef.querySelector(`[data-ui5-stable=${refName}]`) |
There was a problem hiding this comment.
I think most will be in the normal DOM ref so I would put it first (and it can return early, if found) and only then check in the static area dom ref.
Also, if staticAreaItemDomRef is undefined, it will break. Probably you should put a check for both dom refs :)
vladitasev
approved these changes
Oct 19, 2020
ilhan007
pushed a commit
that referenced
this pull request
Nov 11, 2020
ilhan007
pushed a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of the component
Part of #2361