fix(ui5-tabcontainer): implement acc for overflowed items #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
previously requested changes
Jul 31, 2020
| @@ -4,6 +4,9 @@ | |||
| type="{{this.overflowState}}" | |||
| ?selected="{{this.effectiveSelected}}" | |||
| ?disabled="{{this.effectiveDisabled}}" | |||
| ?aria-disabled="{{this.effectiveDisabled}}" | |||
| aria-selected="{{this.effectiveSelected}}" | |||
| aria-labelledby="{{this.ariaLabelledBy}}" | |||
There was a problem hiding this comment.
I think that aria-disabled should be either "true|false" or not set at all. In this case, with "?", it will remain just aria-disabled.
There is also small difference in the VoiceOver announcement. Without the "?", when aria-disabled="true", VoiceOver mentions "dimmed" in addition to the item's text.
But, I am not an expert, you can double check it with our ACC experts.
There was a problem hiding this comment.
Yes, it is not correct to have only aria-disabled with no value. The 'dimmed' announcement is expected.
ilhan007
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2036