-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui5-date-picker): rename component #1801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to also define the old version for some time before breaking it completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing: we have this.getMetadata().getTag(), this _getElementsWithMultipleTags in UI5Element look very strange to me. I would go for a implementation at metadata level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the tags and metadata, I thought about it and I would like to see the following API:
const metadtata = {
tag: "ui5-time-picker",
altTag: "ui5-timepicker"
}
and then in Metadata.js just a new function getAltTag
and for the ones that have it, we'll register it twice.
BREAKING_CHANGE:
ui5-datepicker
is renamed toui5-date-picker