-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-carousel): add navigate event #1454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also the possibility of pages changing due to the user resizing the carousel or the developer removing items from the carousel.
Overall I think pages are unreliable and it would be better to start working with items. I have a change for this, but incomplete. Let's wait until I've merged it and then we can implement the events too
@@ -24,13 +24,15 @@ | |||
{{#if arrows.content}} | |||
<div class="ui5-carousel-navigation-arrows"> | |||
<ui5-button | |||
arrow-back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is used in the test to retrieve the backward arrow in more explicit way, but I guess ui5-carousel-navigation-arrows[0] will work as well, I can change it if you want
The event is fired whenever the selectedIndex changes due to user interaction - when the user clicks on the navigation arrows or while resizing, based on the "items-per-page-s/m/l" properties.
Fixes: #1449