Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-shellbar): Change path in imports for playground #1008

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

ckoutsiaris
Copy link
Contributor

@ckoutsiaris ckoutsiaris commented Dec 3, 2019

Thank you for your contribution! 👏

Based on this https://github.com/SAP/ui5-webcomponents/blob/bdfeb78d6f0e166e17bc8895f54aac179a7752a0/docs/Migration-guides.md#new-npm-package-ui5webcomponents-fiori

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@claassistantio
Copy link

claassistantio commented Dec 3, 2019

CLA assistant check
All committers have signed the CLA.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ckoutsiaris ckoutsiaris changed the title fix: Change path in imports for playground fix(ui5-shellbar): Change path in imports for playground Dec 3, 2019
@ilhan007 ilhan007 merged commit bfe36dd into SAP:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants