-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accessibility Issue: “Ensures every ARIA input field has an accessible name” - for UI5 web components (ui5-list). #1886
Comments
Hi @riteshfsd Just few notes: shouldRenderH1 is not an attribute or property of the List, it is a private read-only getter that calculates if the list header-text is a public API, but from the code you attached I can see that slot="header" is used. And, the slot takes precedence over the "header-text" and the List does not render internal header, but displays the one set with the slot="header". If you remove the <div slot="header", you will see the internal header and aria-labelledby pointing to it: The support of setting aria-labelledBy="label-test" on the |
Add support for aria-label and aria-labelledby: - if aria-label or aria-labelledby are set externally, aria-label is set inside the shadowDOM. - if not, aria-labelledby is set to reference the internal header, when the header-text property is set. It is now possible to label the list as shown: FIXES: #1886
Hello @rimasirich The change: #1899 Also, |
Add support for aria-label and aria-labelledby: - if aria-label or aria-labelledby are set externally, aria-label is set inside the shadowDOM. - if not, aria-labelledby is set to reference the internal header, when the header-text property is set. It is now possible to label the list as shown: FIXES: #1886
Part of #3107 BREAKING CHANGE: The support for ```aria-labelledby``` have been deprecated in favour of new attribute ```accessible-name-ref``` for the following components: - ComboBox (Requested by SF #1916) - DatePicker (Requested by SF #2107) - Input (Requested #1866) - List (Requested by SF #1886) - Rating Indicator - Select (Requested by SF #2107) - StepInput (Implemented as part of the initial implementation #2804) - TextArea (Requested by SF #2107) - WizardStep (Implemented as part of the initial implementation #2400) The ```aria-labelledby``` has been deprecated for the following component: - Button (Requested by SF #1425) The ```accessible-name``` has been deprecated for the following components: - Link (Requested by SF #2356) Both ```aria-labelledby``` and ```accessible-name``` have been deprecated for the following components: - Card (Requested by CBC #2127) - CheckBox (Requested by SF #2265)
Describe the bug
I am facing an issue related to accessibility tests for UI5 web components (ui5-list). Issue description: “Ensures every ARIA input field has an accessible name”
To reproduce
Steps to reproduce the behavior:
Expected behavior
I Should not get the error "Ensures every ARIA input field has an accessible name"
Screenshots
Context
Affected components (if known)
Log output / Any errors in the console
The text was updated successfully, but these errors were encountered: