chore: add '@ui5/theming-ngx' dependency always #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the
@ui5/theming-ngx
package was missing from the projects dependencies.Issue
Prior to this PR,
ng create my-app
npm install @ui5/webcomponents-ngx
,ng serve
@ui5/theming-ngx
could not be resolvedand you need to manually install the
@ui5/theming-ngx
package in addition no matter you want or don't need themingMost probably it was optimisation effort to exclude the package and only add the dependency if the app requires theming. However, it's not working fine. Even if we use
ng add @ui5/webcomponents-ngx
the user is not asked to install it and the result is the same - we will get an error onng serve
.Solution
Add
@ui5/theming-ngx
as dependency unconditionally to avoid breaking on first steps of the usage.Fixes: #62