Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add '@ui5/theming-ngx' dependency always #134

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jun 21, 2024

Prior to this PR the @ui5/theming-ngx package was missing from the projects dependencies.

Issue
Prior to this PR,

  • If you get started from scratch with
    ng create my-app
  • And if you install @ui5/webcomponents-ngx with
    npm install @ui5/webcomponents-ngx,
  • And then use some of the components in the app and run the app
    ng serve
  • you will get an error that an import to @ui5/theming-ngx could not be resolved
    and you need to manually install the @ui5/theming-ngx package in addition no matter you want or don't need theming

Most probably it was optimisation effort to exclude the package and only add the dependency if the app requires theming. However, it's not working fine. Even if we use ng add @ui5/webcomponents-ngx the user is not asked to install it and the result is the same - we will get an error on ng serve.

Solution
Add @ui5/theming-ngx as dependency unconditionally to avoid breaking on first steps of the usage.

Fixes: #62

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for ui5-webcomponents-ngx ready!

Name Link
🔨 Latest commit bc7299b
🔍 Latest deploy log https://app.netlify.com/sites/ui5-webcomponents-ngx/deploys/6675aab3bd17b90008d542b9
😎 Deploy Preview https://deploy-preview-134--ui5-webcomponents-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ilhan007 ilhan007 requested a review from pskelin June 25, 2024 14:03
@ilhan007 ilhan007 merged commit bde3753 into main Jun 25, 2024
8 checks passed
@ilhan007 ilhan007 deleted the chore-theming-ngx-dep branch June 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Dependencies
1 participant