Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates rollup version #3956

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • updates rollup version

Related issue(s)

Resolves #3953 | See also #3955

@ndricimrr ndricimrr self-assigned this Sep 30, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this PR to update rollup wherever possible that includes the following:

  • client-frameworks-support/client-support-angular
  • core
  • test/e2e-test-application
  • website/docs
  • core/examples/luigi-example-angular
  • core/examples/luigi-example-vue
  • core/examples/luigi-example-angular

I think rollup is used there but as a "child" dependency of another dependency. You can find these if you search "rollup" and it will show up in package-lock.jsons that you can use to find out which parent dependency has it as a child and update that. I think this issue is quite popular and many other packages might have already updated rollup internally.

Example: @angular-devkit/build-angular depends on "rollup": "4.20.0", on our luigi-example-angular and it was already bumped on their side here

In case some pacakge that we use hasn't updated their rollup dep then you can note it down in the PR description. (Maybe we can also fix it with "overrides")

container/package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rollup version in repo
2 participants