catch clone_repo exception #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorisOnori
changed the title
marcorosa
requested changes
Mar 24, 2022
There was a problem hiding this comment.
Hi @LorisOnori I have some requests before merging your pull request.
Moreover, please add a reference to the issue you're solving
credentialdigger/client.py
Outdated
Comment on lines
10
to
11
| from github import Github | ||
| from git import GitCommandError |
There was a problem hiding this comment.
Please follow alphabetical order of imports (you can use isort if you don't want to do it manually)
credentialdigger/client.py
Outdated
Comment on lines
993
to
994
| logger.info(f"{i}/{repos_num} Ignore {repo_url} " | ||
| "(it can not be cloned)") |
There was a problem hiding this comment.
please note all the strings are defined by single quotes (') and not double ones (") so we have to be consistent
There was a problem hiding this comment.
the logger is in an exception so it shouldn't be at info level.
Better to use either warning or error
| @@ -100,6 +100,7 @@ def get_git_repo(self, repo_url, local_repo): | |||
| GitRepo.clone_from(repo_url, project_path) | |||
| repo = GitRepo(project_path) | |||
| except GitCommandError as e: | |||
| logger.debug("Repo can not be cloned") | |||
There was a problem hiding this comment.
same comments as before, on quotes and logger level
marcorosa
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
GitCommandErrorexception handler inscan_user. The exception is raised when the repository cannot be cloned. This pull request solves issue #183