-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review] Request from 'digitaltom' @ 'digitaltom/ruby-saml/review_130904_allow_for_settings_authn_context_and_settings_authn_context_decl_ref' #99
[Review] Request from 'digitaltom' @ 'digitaltom/ruby-saml/review_130904_allow_for_settings_authn_context_and_settings_authn_context_decl_ref' #99
Conversation
@digitaltom can you please rebase off the current master (just released |
…text_and_settings_authn_context_decl_ref
@Lordnibbler fixed, please check again. |
@luisvm @inakidelamadrid @pitbulk can you review please? looks ok to me 👍 |
@luisvm @inakidelamadrid @pitbulk review please |
👍 |
1 similar comment
👍 |
@pitbulk any word on this PR? |
@pitbulk please review so we can merge! |
should "create the saml:AuthnContextDeclRef element correctly" do | ||
settings = OneLogin::RubySaml::Settings.new | ||
settings.idp_sso_target_url = "http://example.com" | ||
settings.authn_context_decl_ref = 'suse' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of 'suse' use 'http://example.com/declaration_ref'
(review the test)
There is no documentation on the PR, neither example values for the fields. |
I gonna close this PR, we will merge #152 |
This adds support for a AuthnContextDeclRef element inside RequestedAuthnContext.
It looks like this:
We need that for choosing a login page on our saml provider on sp initiated requests.