-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sha2: fix aarch64 implementation being disabled #569
Conversation
Thanks! |
works quite well, too: on a GH200 the aarch64.rs code runs at 1.7 GiB/s (versus 0.4 GiB/s for the soft implementation), OpenSSL 3 is just shy of 2 GiB/s. |
We can probably switch from inline ASM back to the intrinsics at this point, given the current MSRV |
Looks like these only landed in 1.76: https://doc.rust-lang.org/core/arch/aarch64/fn.vsha256su0q_u32.html |
I couldn't even get them to work on 1.76, despite the documentation making it look like they should work: https://github.com/RustCrypto/hashes/actions/runs/8251432049/job/22568457459 |
Oh, perhaps the SHA-256 intrinsics were stabilized, but the SHA-512 ones weren't? |
Looks like it, that's a bit odd. |
Here's the stabilization PR: https://github.com/rust-lang/stdarch/pull/1399/files I don't even see where e.g. Gated under |
Opened #571 to track this |
Fixes #568
(eref 42d478fb6976)