rc5: unlock parameter size, add u128 and u8 word size support. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedNeon
force-pushed
the
rc5
branch
2 times, most recently
from
fe20059
to
1f4ff69
Compare
NamedNeon
changed the title
… key, and round size generics; deprecated old predefined RC5 types
|
This is ready for review now. I unintentionally set it as ready last night and didn't realize until this morning, so apologies for that. I don't make pull requests very often. |
tarcieri
reviewed
Sep 3, 2023
tarcieri
reviewed
Sep 3, 2023
Co-authored-by: Tony Arcieri <bascule@gmail.com>
|
Hi, it has been a few months so I figured I'd just leave a message here to see if anything further is needed from me before this can be reviewed and hopefully merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #381.