dasp::Frame: Generic impl for all [impl Sample;const N: usize]
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I chose to leave out the custom impl:s of |
|
Would solve issue #179. |
rawler
changed the title
[impl Sample;const N: usize][impl Sample;const N: usize]
Replace the hard-coded macro implementing `Frame` for `[impl Sample;0-32]`, with a generic impl based on const-generics. I discovered the need for this, when trying to simplify some macro- -implementations in the `ebur128` crate with const-generics. We cannot remove the need for `NumChannels`, since (see reference 1) "Associated Const Equality" is not yet stable. We can however adapt the `NumChannels` strategy from `N1..N32` to a `NChannels<N>`-generic type. Some opportunities like removing `unsafe` from `zip_map`, remain out of reach due to pending stabilization of the standard library. 1: rust-lang/rust#92827
rawler
force-pushed
the
generic-frame-impl
branch
from
e922fe6
to
885825f
Compare
|
I'd be interested in seeing this functionality get added - is there a particular reason this never got merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the hard-coded macro implementing
Framefor[impl Sample;0-32], with a generic impl based on const-generics.I discovered the need for this, when trying to simplify some macro- -implementations in the
ebur128crate with const-generics.We cannot remove the need for
NumChannels, since (see reference 1) "Associated Const Equality" is not yet stable. We can however adapt theNumChannelsstrategy fromN1..N32to aNChannels<N>-generic type.Some opportunities like removing
unsafefromzip_map, remain out of reach due to pending stabilization of the standard library.1: rust-lang/rust#92827