Add Windows bundled builds to CI #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The debug builds fails with the missing dll, probably fixed by #1093. However the release builds get a very strange error:
Honestly I've never seen that before. |
|
Yes I was about to write about that. Seems like test_audio_cvt has been crashing with heap corruption on the --release Windows build for a while. See #1092 for confirmation that it is the only test crashing out. |
This was referenced Apr 19, 2021
|
This looks ready FYI. |
|
Thanks a lot! |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Add Windows bundled builds to CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add [static-link, dynamic] X [debug, release] builds of windows-latest "bundled" to CI.