Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch cleanup #366

Closed
wants to merge 2 commits into from
Closed

Dispatch cleanup #366

wants to merge 2 commits into from

Conversation

RocketMan
Copy link
Owner

This PR refactors the top-level actions addTrack and moveTrack to stemmed actions under editList; namely, editListAddTrack and editListMoveTrack, respectively.

In this way, we lose the overhead of extra routing at the top level and instead delegate it to Playlist.

This is a non-semantic change.

@RocketMan RocketMan added this to the v2.11.8 milestone Nov 18, 2022
@RocketMan
Copy link
Owner Author

Closing, as ideally, both of these operations would move to the JSON:API.

For that to happen, we'll need to address a couple things:

  • addTrack contains a UI fragment in its response that our JSON:API equivalent does not provide. We'll want to do that in a way that is reasonable for both the API and the application architecture;
  • moveTrack performs track resequencing, and while there are several examples of similar operations in REST APIs (See Spotify and Google), there is no definitive, best practice to guide us.

@RocketMan RocketMan closed this Nov 19, 2022
@RocketMan RocketMan deleted the dispatch-cleanup branch November 19, 2022 10:08
@RocketMan RocketMan removed this from the v2.11.8 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant