Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Project-restructure #217

Merged
merged 3 commits into from
Jul 1, 2023
Merged

[IMPROVE] Project-restructure #217

merged 3 commits into from
Jul 1, 2023

Conversation

abhinavkrin
Copy link
Member

Brief Title

This PR introduces mono repo to our EmbeddedChat project.

Acceptance Criteria fulfillment

  • Converted the project into mono repo
  • Created auth package for embeddedchat. It now supports password flow and oauth token flow.
  • Restructed API into @embeddedchat/api package and used @embedded/auth for all authentication purpose.
  • Created playground for both auth and API package.

Fixes #216 #215 #214

Video/Screenshots

playground_api

@abhinavkrin
project-restructure
9603d3b 
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin
minor fixes
ad98191 
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin
minor fixes
f355579 
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@sidmohanty11 sidmohanty11 self-requested a review July 1, 2023 14:35
sidmohanty11
sidmohanty11 approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhinavkrin LGTM

@sidmohanty11 sidmohanty11 merged commit c070543 into RocketChat:develop Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidmohanty11 sidmohanty11 sidmohanty11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavkrin @sidmohanty11