prevents empty text from being rendered #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mesh.rotation.x = Math.PI * 0.5; | ||
| mesh.rotation.y = Math.PI * 1.5; | ||
| this.add(mesh); | ||
| // position the text and add it |
There was a problem hiding this comment.
Stupid question: did these lines change?
There was a problem hiding this comment.
Indentation changed due to the if statement!
There was a problem hiding this comment.
Oh of course. It was not obvious in my browser. :)
sosentos
added a commit
that referenced
this pull request
Aug 7, 2014
prevents empty text from being rendered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing a bounding box on https://github.com/rctoris/ros3djs/compare/RobotWebTools:develop...develop#diff-ed07448aa3074b47ea2aa22b6bd8b70fL235 causes an error if the empty string was rendered. This prevents any empty strings from being "displayed."