Custom frame axes options: scale, dashed lines and no pan&zoom frame #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2018 16:56
viktorku
changed the title
T045T
reviewed
Jan 15, 2018
| line.position.copy(axis); | ||
| // Make spacing between dashes equal to 1.5 times the dash length. | ||
| line.position.multiplyScalar(l / 2 + 3 * l * i); | ||
| line.quaternion.copy(rot); |
There was a problem hiding this comment.
There's a few duplicated lines here - can you refactor the code to move them outside the if-else?
There was a problem hiding this comment.
They are not duplicated, but inside a for loop. The de-duplication would make reasoning about this harder.
jihoonl
requested changes
Jan 18, 2018
| @@ -61,17 +69,19 @@ ROS3D.OrbitControls = function(options) { | |||
| }; | |||
| var state = STATE.NONE; | |||
|
|
|||
| // add the axes for the main coordinate frame | |||
| this.axes = new ROS3D.Axes({ | |||
There was a problem hiding this comment.
this.axes isn't used if displayPanAndZoomFrame is false. Could you move this under if statement? And update showAxes() something like
if(this.displayPanAndZoomFrame){
var that = this;
this.axes.traverse(function(obj) {
obj.visible = true;
});
if (this.hideTimeout) {
clearTimeout(this.hideTimeout);
}
this.hideTimeout = setTimeout(function() {
that.axes.traverse(function(obj) {
obj.visible = false;
});
that.hideTimeout = false;
}, 1000);
}
|
It is an interesting feature that I would like to merge in. @viktorku any updates? |
jihoonl
approved these changes
Feb 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ability to optionally specify:
AxesandOrbitControl's "temporary" pan and zoom frame line type to"dashed"and custom scale, as it would be nice if we display some frames with a different scale/line-type (besides the thicknes - which we can already do customize).Backwards compatibility with default values is being retained, but please confirm.
Credits go to @sdeleersnijder ;)