This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
parameterize max_depth_per_tile #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolfo-rt
approved these changes
Jan 10, 2018
|
Currently, I don't have any ubuntu machine to test. I will review it as soon as I get the machine within this week probably. |
jihoonl
approved these changes
Jan 12, 2018
|
All looks good. But, I feel bad to merge this in with CI failure. I will merge this after fixing travis via #9 |
This was referenced Oct 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ability to change the
max_depth_per_tilefactor so we can control the desired depth range. A PR to allow a tunable range in theDepthCloudwill shortly follow.