[92] Create Record with BSON Type Information #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oaedward
previously approved these changes
Sep 23, 2023
|
Align schema with DB Schema Docs |
|
@oaedward I agree that the schema here should be aligned with the DB schema docs. However, I think it's best to put that in as a separate PR since this PR is meant to be a non-functional change. Once this PR is in, we can add another PR to align the current schema. Thoughts? cc @akshaypuli |
Currently, ObjectID type information is lost when sending JSON over from the client to the server. This change adds BSON support that can be used to transfer type information alongside the data.
irushavm
force-pushed
the
feature/92/store-ids-as-objectid
branch
from
204af17
to
c1b5688
Compare
irushavm
force-pushed
the
feature/92/store-ids-as-objectid
branch
from
c1b5688
to
8e718bf
Compare
|
I totally agree. |
oaedward
approved these changes
Oct 15, 2023
akshaypuli
approved these changes
Oct 15, 2023
akshaypuli
added a commit
that referenced
this pull request
Oct 15, 2023
* [96] Add Department Record Creation (#97) * [96] Add Department Record Creation Add backend support to create Department records * Refactor CREATE_RECORDS to use a list of supported collections * [92] Create Record with BSON Type Information (#95) * [92] Create Record with BSON Type Information Currently, ObjectID type information is lost when sending JSON over from the client to the server. This change adds BSON support that can be used to transfer type information alongside the data. * Added unit test that can be run with "npm run test" * [98]Feature/align-ui-with-Figma (#99) * align design with figma * align with figma design * purchase details aligned with figma * Department Collection Created * Comment out Purchase Details --------- Co-authored-by: Akshay <akshaypuli@outlook.com> * [100] Site Dashboard Overview (#101) * align design with figma * align with figma design * purchase details aligned with figma * Department Collection Created * Comment out Purchase Details * Dashboard overview page created * update css global styles * convert UI-Landing to Dashboard directory * dashboard-model view designed * dashboard interface designed * re-align detail page * Align record with db schema --------- Co-authored-by: Akshay <akshaypuli@outlook.com> --------- Co-authored-by: Irusha Vidanamadura <irushavm@users.noreply.github.com> Co-authored-by: Edward Opoku-Agyemang <87245788+oaedward@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, ObjectID type information is lost when sending JSON over from the client to the server. This change adds BSON support that can be used to transfer type information alongside the data.
Related Issue
#92
Motivation and Context
How Has This Been Tested?
Tested the Vendor Creation flow and verified that the listing of Vendors work as-is. However, more tests are needed here.
Screenshots (if appropriate):