Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23] Extend FIND_RECORDS to find by ID #62

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

irushavm
Copy link

@irushavm irushavm commented Feb 4, 2023

Description

Changes Made:

  • Add docs on BIOMD API interface
  • Add eq_id operation in FIND call where the Value will be encapsulated in the Mongo ObjectId

Related Issue

#23

How Has This Been Tested?

Using API Testing Tool

akshaypuli
akshaypuli previously approved these changes Feb 5, 2023
Copy link
Contributor

@akshaypuli akshaypuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using Test Case # 5. Functioning as intended

@akshaypuli akshaypuli changed the base branch from dev-v010 to dev-v020 February 5, 2023 05:37
@akshaypuli akshaypuli dismissed their stale review February 5, 2023 05:37

The base branch was changed.

@akshaypuli akshaypuli changed the base branch from dev-v020 to dev-v010 February 5, 2023 05:37
@akshaypuli
Copy link
Contributor

Need to change the base branch to dev-0.2.0

@irushavm irushavm changed the base branch from dev-v010 to dev-v020 February 5, 2023 17:33
irushavm and others added 3 commits February 5, 2023 17:05
Changes Made:
- Add docs on BIOMD API interface
- Add eq_id operation in FIND call where the Value will be encapsulated in the Mongo ObjectId
@irushavm irushavm force-pushed the user/irushavm/23-api-find-record-by-id branch from 87b6e0b to f38ec57 Compare February 6, 2023 01:05
@irushavm irushavm merged commit 45f9335 into develop Feb 16, 2023
@irushavm irushavm deleted the user/irushavm/23-api-find-record-by-id branch February 16, 2023 23:48
@akshaypuli
Copy link
Contributor

@irushavm We should revert this PR. There is an issue with including YAML files within the API directory. I am working on a fix. For now, I would only include changes to the API in this PR and move the YAML files to another branch.

irushavm added a commit that referenced this pull request Feb 18, 2023
@irushavm irushavm restored the user/irushavm/23-api-find-record-by-id branch February 18, 2023 21:03
@irushavm irushavm deleted the user/irushavm/23-api-find-record-by-id branch February 18, 2023 23:25
@irushavm
Copy link
Author

@akshaypuli Ah I see the error now. I have some thoughts on how this can be solved.

irushavm added a commit that referenced this pull request Feb 20, 2023
irushavm added a commit that referenced this pull request Mar 12, 2023
Changes Made:
- Add docs on BIOMD API
- Add eq_id operation in FIND API
akshaypuli pushed a commit that referenced this pull request Apr 16, 2023
[23] Extend FIND_RECORDS to find by ID

Changes Made:
- Add eq_id operation in FIND API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants