Fix SLATRS3 and CLATRS3 tests #764
Conversation
Some SLATRS3 tests were failing with OpenBLAS where the RHS has a BIGNUM (=Infinity in this test) component. OpenBLAS SSCAL, when multiplying with 0, will turn this component into 0, unlike reference BLAS which turns it into NaN. While NaN looks more correct it still did not explain why DLATRS3 tests were succeeding where DSCAL has the same difference between reference and OpenBLAS. Diffing the test code unmasked a few bugs, which makes the test succeed and also unmasked a bug in the CLATRS3 test. The ZLATRS3 and DLATRS3 tests look correct to me.
|
I just see #755 overlaps this with one chunk for the SLATRS3 test, however misses the other fixes here (mostly for CLATRS3) |
| @@ -541,7 +541,7 @@ SUBROUTINE CCHKTR( DOTYPE, NN, NVAL, NNB, NBVAL, NNS, NSVAL, | |||
| * | |||
| SRNAMT = 'CLATRS3' | |||
| CALL CCOPY( N, X, 1, B, 1 ) | |||
| CALL CCOPY( N, X, 1, B, 1 ) | |||
| CALL CCOPY( N, X, 1, B( N+1 ), 1 ) | |||
|
Thanks, looks good. 👍 |
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1908 1908
Lines 187074 187074
=======================================
Misses 187074 187074 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@weslleyspereira Just wondering why this has been approved but not merged? Is there an issue somewhere? |
Some SLATRS3 tests were failing with OpenBLAS where the RHS has a BIGNUM (=Infinity in this test) component. OpenBLAS SSCAL, when multiplying with 0, will turn this component into 0, unlike reference BLAS which turns it into NaN. While NaN looks more correct it still did not explain why DLATRS3 tests were succeeding where DSCAL has the same difference between reference and OpenBLAS.
Diffing the test code unmasked a few bugs, which makes the test succeed and also unmasked a bug in the CLATRS3 test.
The ZLATRS3 and DLATRS3 tests look correct to me.
@angsch can you please review as test author (#651)?